Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Item validation rules and add support for py3.12 #134

Closed
wants to merge 5 commits into from

Conversation

thomas-maschler
Copy link
Contributor

  • Require type property to be set for Catalog and Collections
  • Fix validator for Item datetime and Common MetaData start_datetime and end_datetime
  • Make sure all datetime fields are correctly parsed
  • Include datetime and license to Common MetaData
  • Make sure default values for required but unset fields are correctly parsed
  • Add support from Python 3.12
  • Lint all files
  • Increase test coverage

@vincentsarago
Copy link
Member

thank for this great PR @thomas-maschler, I wonder if you've seen #131 where we talked specifically about the datetime validation/parsing

@thomas-maschler
Copy link
Contributor Author

@vincentsarago, I just noticed that PR. Should have checked first. However, this PR is mostly complementary.

I could either wait until #131 is merged into main or merge those changes into mine to consolidate.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c03272e). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage        ?   96.99%           
=======================================
  Files           ?       26           
  Lines           ?      632           
  Branches        ?        0           
=======================================
  Hits            ?      613           
  Misses          ?       19           
  Partials        ?        0           
Flag Coverage Δ
unittests 96.99% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-maschler
Copy link
Contributor Author

Closing this PR in favor of #135. The new PR is branched of #131 and I will keep it in draft until #131 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants