Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor datetime parsing and validation #133

Conversation

vincentsarago
Copy link
Member

ref #132 (comment)

A while ago stac-fastapi moved to ciso8601 and then to pyiso8601 (stac-utils/stac-fastapi#448) but I think now it's safe to use ciso8601 for datetime parsing and validation (at least if using ~=2.3, developmentseed/tipg#39 (comment))

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@75304a5). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage        ?   96.81%           
=======================================
  Files           ?       26           
  Lines           ?      597           
  Branches        ?        0           
=======================================
  Hits            ?      578           
  Misses          ?       19           
  Partials        ?        0           
Flag Coverage Δ
unittests 96.81% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski merged commit 416225e into stac-utils:main Feb 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants