Refactor/pgstac version tests #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Oct 28, 2025
| "brotli_asgi", | ||
| "cql2>=0.3.6", | ||
| "pypgstac>=0.8,<0.10", | ||
| "pypgstac>=0.9,<0.10", |
Member
Author
There was a problem hiding this comment.
This could be considered as a breaking change but IMO a minor version release should be fine
vincentsarago
force-pushed
the
refactor/pgstac-version-tests
branch
from
7d9938b to
ff7b02b
Compare
…ils/stac-fastapi-pgstac into refactor/pgstac-version-tests
Member
Author
|
tests ran at https://github.com/stac-utils/stac-fastapi-pgstac/actions/runs/18879804290 🟢 it takes around 16min now, I'll create an issue to try to reduce this |
gadomski
approved these changes
Oct 28, 2025
vincentsarago
added a commit
that referenced
this pull request
Oct 30, 2025
* check potential issue with change of collection body * adapt tests * more tests * update * update docs * remove space * Update README.md * exclude hydrate markers * Refactor/pgstac version tests (#305) * update pypgstac version and tests multiple versions * use python 3.11 * revert --------- Co-authored-by: Pete Gadomski <[email protected]>
vincentsarago
commented
Nov 24, 2025
| "0.9.8", | ||
| ], | ||
| autouse=True, | ||
| ) |
Member
Author
There was a problem hiding this comment.
ref #318
🤦 we are not using the version anywhere so we end up only testing the latest version provided by pypgstac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #303 the tests are failing because we install
pypgstac==0.8.xwhich doesn't use thehydraterspackage.We can still tests PgSTAC
0.8.xbut using pypgstac0.9.x. This PR refactor the CI and tests to test both versions and add more python version to the matrixThe tests are a bit longer to run because we have 2 matrices: PgSTAC_version / hydration-prefix-validation. I believe we should refactor the tests in another PR to remove the second matrix