refactor pgstacDb class #375
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Jul 9, 2025
| dsn: str | ||
| commit_on_exit: bool = True | ||
| debug: bool = False | ||
| use_queue: bool = False |
There was a problem hiding this comment.
removed possibility to pass a Connection object which adds to much complexity
vincentsarago
commented
Jul 9, 2025
| if self.pool is not None: | ||
| self.pool.close() | ||
| if self._pool is not None: | ||
| self._pool.close() |
There was a problem hiding this comment.
only close pool if we created it
vincentsarago
commented
Jul 9, 2025
|
|
||
| @contextlib.contextmanager | ||
| def connect(self) -> Connection: |
There was a problem hiding this comment.
connect() should be use in a context manager
with PgstacDb(dsn=...) as db:
with db.connect() as conn:
...
vincentsarago
commented
Jul 9, 2025
|
|
||
| conn: Connection = None | ||
| try: | ||
| conn = pool.getconn() |
There was a problem hiding this comment.
we could also switch to
with pool.connection() as conn:
vincentsarago
commented
Jul 9, 2025
| @@ -28,7 +29,9 @@ def __init__( | |||
| sys.exit(0) | |||
|
|
|||
| self.dsn = dsn | |||
| self._db = PgstacDB(dsn=dsn, debug=debug, use_queue=usequeue) | |||
There was a problem hiding this comment.
decided not to hold a PgSTACDb object in self but instead create it within each subcommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve #340 by completely refactoring the PgstacDb class and its usage by other classes/methods