-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add unit tests #13
base: main
Are you sure you want to change the base?
Conversation
Thanks! I guess we can't expect from every extension author to be able to write JS and as such make the CI work propertly. So this seems like an "optional" package that extension authors should be able to choose from, but I'm not sure how we could enable this through GitHub... ideas? Maybe just put it into a separate branch that people could merge? |
I'd expect anyone who is capable of actually writing JSON Schema to be able to understand and adapt the JS tests pretty quickly. But I could make it something which is easily ripped out by anyone who doesn't want it (basically remove a few files). How about that? |
4c55a27
to
3b4c22c
Compare
Changed to Jest. |
3b4c22c
to
060ae37
Compare
Co-authored-by: Mitchell Paff <[email protected]> Co-authored-by: Victor Engmark <[email protected]>
Makes it easier to debug.
02f084d
to
ebe6bce
Compare
Any update on this? Is a section in the readme mentioning how it's optional or how to use it warranted? |
Ping? |
As we are usually trying to merge changes in the template into the downstream extensions, this would eventually hit all the existing repos. Who is willing to do this work for all these repos? Also, as extension authors often don't even get the JSON Schemas right (means: I'm doing it), I don't see them writing tests in JS (quite a number are not JS programmers). As such I'd personally not merge this. If you feel strongly about this please reach out to the STAC PSC via e-mail so that we can discuss this: [email protected] |
These tests would give them an idea how to write them, and they would be easy to disable for anyone who really doesn't care whether their schema actually works. But if even that isn't convincing, I'll just close it. |
Discussed at the STAC spring: We leave this open if people want to integrate it, but we don't want to ship this by default. |
Based on https://github.com/linz/stac; closes #9.
Co-authored-by: Mitchell Paff [email protected]
Co-authored-by: Victor Engmark [email protected]