Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add unit tests #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Oct 10, 2021

Based on https://github.com/linz/stac; closes #9.

Co-authored-by: Mitchell Paff [email protected]
Co-authored-by: Victor Engmark [email protected]

@m-mohr
Copy link
Contributor

m-mohr commented Nov 1, 2021

Thanks! I guess we can't expect from every extension author to be able to write JS and as such make the CI work propertly. So this seems like an "optional" package that extension authors should be able to choose from, but I'm not sure how we could enable this through GitHub... ideas? Maybe just put it into a separate branch that people could merge?

@l0b0
Copy link
Contributor Author

l0b0 commented Nov 18, 2021

I'd expect anyone who is capable of actually writing JSON Schema to be able to understand and adapt the JS tests pretty quickly. But I could make it something which is easily ripped out by anyone who doesn't want it (basically remove a few files). How about that?

@l0b0 l0b0 marked this pull request as draft December 13, 2021 01:48
@l0b0 l0b0 marked this pull request as ready for review December 13, 2021 02:28
@l0b0 l0b0 force-pushed the feat/add-unit-tests branch from 4c55a27 to 3b4c22c Compare December 13, 2021 02:43
@l0b0
Copy link
Contributor Author

l0b0 commented Dec 13, 2021

Changed to Jest.

@l0b0 l0b0 force-pushed the feat/add-unit-tests branch from 3b4c22c to 060ae37 Compare December 13, 2021 02:58
@l0b0 l0b0 force-pushed the feat/add-unit-tests branch from 02f084d to ebe6bce Compare December 14, 2021 00:37
@l0b0
Copy link
Contributor Author

l0b0 commented Sep 7, 2022

Any update on this? Is a section in the readme mentioning how it's optional or how to use it warranted?

@l0b0
Copy link
Contributor Author

l0b0 commented Feb 13, 2023

Ping?

@m-mohr
Copy link
Contributor

m-mohr commented Feb 13, 2023

As we are usually trying to merge changes in the template into the downstream extensions, this would eventually hit all the existing repos. Who is willing to do this work for all these repos? Also, as extension authors often don't even get the JSON Schemas right (means: I'm doing it), I don't see them writing tests in JS (quite a number are not JS programmers). As such I'd personally not merge this. If you feel strongly about this please reach out to the STAC PSC via e-mail so that we can discuss this: [email protected]

@l0b0
Copy link
Contributor Author

l0b0 commented Feb 13, 2023

Also, as extension authors often don't even get the JSON Schemas right (means: I'm doing it), I don't see them writing tests in JS (quite a number are not JS programmers).

These tests would give them an idea how to write them, and they would be easy to disable for anyone who really doesn't care whether their schema actually works. But if even that isn't convincing, I'll just close it.

@m-mohr
Copy link
Contributor

m-mohr commented Oct 2, 2023

Discussed at the STAC spring: We leave this open if people want to integrate it, but we don't want to ship this by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Non-conformant examples
2 participants