Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators per operator cap: 500 to 1000 #513

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

MatheusFranco99
Copy link
Contributor

Overview

This PR implements the spec changes associated with the update of the number of validators per operator from 500 to 1000.

Namely, it changes the number of signatures allowed in the PartialSignatureMessages structure.

* Solve entropy in simple case in which a fixed key can be used

* Solve entropy in test type by changing the test spec: removing CypherText and using fixed keys
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in the description. link to the SIP

@GalRogozinski
Copy link
Contributor

@MatheusFranco99
btw, please add a PR on top of #491
don't change 491 since it will be a fork

@MatheusFranco99
Copy link
Contributor Author

@GalRogozinski
My implementation is already adjusted to min(2*validators, validators + sync_committee_size). So I think we don't need a PR on top of it

Copy link
Contributor

@moshe-blox moshe-blox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@GalRogozinski GalRogozinski merged commit 6ddad5b into ssvlabs:dev Dec 19, 2024
2 checks passed
@GalRogozinski GalRogozinski deleted the validators-per-operator-1k-cap branch December 19, 2024 09:40
GalRogozinski pushed a commit that referenced this pull request Dec 19, 2024
* reset on dev

* Tests - Remove entropy in tests (#507)

* Solve entropy in simple case in which a fixed key can be used

* Solve entropy in test type by changing the test spec: removing CypherText and using fixed keys

* udpate max signatures in PartialSignatureMessages

* update max signatures in maxmsgsize tests

* generate JSON tests
GalRogozinski pushed a commit that referenced this pull request Dec 19, 2024
* reset on dev

* Tests - Remove entropy in tests (#507)

* Solve entropy in simple case in which a fixed key can be used

* Solve entropy in test type by changing the test spec: removing CypherText and using fixed keys

* udpate max signatures in PartialSignatureMessages

* update max signatures in maxmsgsize tests

* generate JSON tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants