Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Misaligned terms #349

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix - Misaligned terms #349

wants to merge 7 commits into from

Conversation

MatheusFranco99
Copy link
Contributor

@MatheusFranco99 MatheusFranco99 commented Jan 17, 2024 •
edited
Loading

Goal

Align field names according to official spec, solving issue #220.

Previous

In Message, we have:

RoundChangeJustification
PrepareJustification

Usage:

  • In Round-Change messages, RoundChangeJustification holds Prepare messages.
  • In Proposal messages, RoundChangeJustification holds Round-Change messages, and PrepareJustification holds prepare messages.

New

In Message, we drop PrepareJustification to use the name ProposalJustification.
Usage:

  • In Round-Change messages, RoundChangeJustification holds Prepare messages (same).
  • In Proposal messages, RoundChangeJustification holds Prepare messages, and ProposalJustification holds Round-Change messages.

@MatheusFranco99 MatheusFranco99 self-assigned this Jan 17, 2024
@GalRogozinski GalRogozinski self-requested a review January 17, 2024 08:56
GalRogozinski
GalRogozinski approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MatheusFranco99 MatheusFranco99 mentioned this pull request Jan 31, 2024
Open
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalRogozinski GalRogozinski GalRogozinski approved these changes

@MatusKysel MatusKysel MatusKysel approved these changes

@y0sher y0sher y0sher approved these changes

@moshe-blox moshe-blox Awaiting requested review from moshe-blox

Assignees

@MatheusFranco99 MatheusFranco99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatheusFranco99 @y0sher @MatusKysel @GalRogozinski