feat - validator redirects #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshe-blox
reviewed
Jan 16, 2025
Comment on lines
+100
to
117
| // Check for duplicate keys in OwnerRedirects. | ||
| ownerSeen := make(map[string]struct{}) // Separate map for OwnerRedirects | ||
| for from := range mechanics.OwnerRedirects { | ||
| if _, exists := ownerSeen[from.String()]; exists { | ||
| return fmt.Errorf("duplicate owner redirect key: %s", from.String()) | ||
| } | ||
| ownerSeen[from.String()] = struct{}{} | ||
| } | ||
|
|
||
| // Check for duplicate keys in ValidatorRedirects. | ||
| validatorSeen := make(map[string]struct{}) // Separate map for ValidatorRedirects | ||
| for from := range mechanics.ValidatorRedirects { | ||
| if _, exists := validatorSeen[from.String()]; exists { | ||
| return fmt.Errorf("duplicate validator redirect key: %s", from.String()) | ||
| } | ||
| validatorSeen[from.String()] = struct{}{} | ||
| } | ||
| } |
There was a problem hiding this comment.
these checks will always pass as they're checking duplicate keys in a map (impossible)
i think the duplicate check can be in the load from CSV (where duplicates are possible)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.