Better handling of common errors when measuring peer count in eth1 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zktaiga
approved these changes
Nov 25, 2024
| @@ -20,10 +20,13 @@ const ( | |||
| PeerCountMeasurement = "Count" | |||
| ) | |||
|
|
|||
| var measuringErr = errors.New("UNABLE_TO_MEASURE") | |||
There was a problem hiding this comment.
golang best practice for predefined errors is to store them in separate files like error.go, but it isn't a blocker
There was a problem hiding this comment.
I see your point. I would say it's pretty common to declare errors in the file with some other objects. It depends on the size of the file or package, etc. If there are more package level errors, then we can move it to a separate file. Good suggestion
vaclav-ssvlabs
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Execution Clients do not support (or may have optionally disabled) the endpoint that provides the number of peers. This happens fairly often, and the previous implementation would output a peer count of
0in such cases, which is misleading. This PR addresses the issue by outputting a custom error message to clarify the Unhealthy status. While we could potentially clear the Unhealthy status, doing so would require additional implementation and might complicate the code. For now, this solution should be sufficient.New:
Old:
