-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed to allow offline splitting of validator keys with different passwords #69
base: main
Are you sure you want to change the base?
Changes from 5 commits
6912627
b57a7cc
e105570
f7d0f26
23d7341
0fb3adf
11f39a4
805504d
a501324
96f9b0e
2a43fac
1771821
0ad5718
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,19 +91,38 @@ To run you will use the "shares" command | |
|
||
**Input parameters:** | ||
- keystore (ks) = The path to either a validator keystore file or a folder that contains multiple validator keystore files. If a folder is provided, it will split in bulk all the keystore files within it according to the additional arguments provided | ||
- password (ps) = The keystore file encryption password, if a folder was provided the password will be used for all keystore files in the folder | ||
- password (ps) = The keystore file encryption password. For one keystore, enter the absolute path. For multiple keystores, enter only the password file name. | ||
- operator-ids (oids) = Comma-separated list of operator IDs. The amount must be 3f+1 compatible | ||
- operator-keys (oks) = Comma-separated list of operator keys (same sequence as operator ids). The amount must be 3f+1 compatible | ||
- output-folder (of) = Target folder path to output the key shares file | ||
- owner-address (oa) = The cluster owner address (in the SSV contract) | ||
- owner-nonce (on) = The validator registration nonce of the account (owner address) within the SSV contract (increments after each validator registration), obtained using the ssv-scanner tool | ||
|
||
```bash | ||
|
||
6 directories, 20 files | ||
# single file | ||
yarn cli shares --keystore=keystore.json --password=test --operator-ids=1,2,3,4 --operator-keys=LS..,LS..,LS..,LS.. --output-folder=./ --owner-address=... --owner-nonce=.. | ||
yarn cli shares --keystore=./keystore.json --password=./password.txt --operator-ids=1,2,3,4 --operator-keys=LS..,LS..,LS..,LS.. --output-folder=./ --owner-address=... --owner-nonce=.. | ||
|
||
# folder with multiple keystore files | ||
yarn cli shares --keystore=./keystore-files --password=test --operator-ids=1,2,3,4 --operator-keys=LS..,LS..,LS..,LS.. --output-folder=./ --owner-address=... --owner-nonce=.. | ||
## folder structure | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Separate this usecase with this sub header Add sub header for one password and multiple files. Command should be the same as before change There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated. |
||
keystore_folders | ||
├── 0xe020.... | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. validator public key is redundant as folder name - change to something generic There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated! |
||
│ ├── keystore-m_12381_3600_1_0_0-1717971132.json | ||
│ └── password.txt | ||
├── 0xe025.... | ||
│ ├── keystore-m_12381_3600_6_0_0-1717971134.json | ||
│ └── password.txt | ||
├── 0xe02a.... | ||
│ ├── keystore-m_12381_3600_11_0_0-1717971135.json | ||
│ └── password.txt | ||
├── 0xe02f.... | ||
│ ├── keystore-m_12381_3600_16_0_0-1717971137.json | ||
│ └── password.txt | ||
└── 0xe034.... | ||
├── keystore-m_12381_3600_21_0_0-1717971139.json | ||
└── password.txt | ||
yarn cli shares --keystore=./keystore_folders --password=password.txt --operator-ids=1,2,3,4 --operator-keys=LS..,LS..,LS..,LS.. --output-folder=./ --owner-address=... --owner-nonce=.. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. instead "password.txt" write here and in the folder structure - the name and extension are not important as long as file can be read as utf-8 encoded text There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried to convey that it can be a simple file without an extension. |
||
``` | ||
|
||
**Output:** Name will start with keyshares-timestamp.json | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this change, user will continue using plane password as parameter