Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search in history and bookmarks #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dbuezas
Copy link
Contributor

@dbuezas dbuezas commented Aug 9, 2017

I'm using the new search in history a lot :).
In combination with the tab search I don't even care what tabs are open. Feels really like the file palette of sublime/atom but with web pages
(builds upon Pull request 16)

@dbuezas dbuezas force-pushed the feature/search-in-history-and-bookmarks branch 2 times, most recently from 2a676df to 4df6ce2 Compare August 9, 2017 22:36
@dbuezas
Copy link
Contributor Author

dbuezas commented Aug 9, 2017

screen shot 2017-08-10 at 00 52 21

screen shot 2017-08-10 at 00 52 06

@dbuezas
Copy link
Contributor Author

dbuezas commented Aug 10, 2017

BTW: one must do extension reload since it requires new permisions for bookmarks and history

@ssundarraj
Copy link
Owner

Hey, can you merge with master so I can just see the new diff?

@dbuezas dbuezas force-pushed the feature/search-in-history-and-bookmarks branch from 4df6ce2 to 57967cf Compare August 11, 2017 09:11
@dbuezas
Copy link
Contributor Author

dbuezas commented Aug 11, 2017

Currently it only uses recent history, I need to do some optimizations for it to work with the whole history without being sluggish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants