Generalize serialize to support more containers in a generalized way, and store mapping name in a stack stored in the serializer #1271

leekillough · 2025-03-23T07:33:05Z

In addition to the comments here, this PR:

Places the names used in the serializer for mapping into a stack in the serializer class. The names can be pushed on and popped off the stack to support multiple recursion levels of serialization. A name will be pushed on the stack when the SST_SER() macro is called, and then when serializations occur recursively, they will push another name (or no name if the current top name should be retained), etc., and when a serialization ends, the stack will be popped. The name does not need to be passed through the serialization function arguments, and the functions do not need to be duplicated with and without the name arguments. ser.getMapName() will return the last name pushed on the stack. (Another name for these map name functions can be used if desired.)
Refactors serialize_impl to support more containers in a generalized way
- Make the default serialize_impl template for user-defined non-polymorphic classes much shorter, using the same code for pointers and non-pointers
- Add serialize_insertable.h and serialize_utility.h to support all sequenced and associative containers in one specialization
  - std::vector, std::vector<bool>, std::list, std::deque, std::map, std::multimap, std::set, std::multiset, std::unordered_map, std::unordered_multimap, std::unordered_set, std::unordered_multiset
  - This "insertable" serialize_impl partial specialization is selected based on the existence of class types and methods it depends on, such as value_type, begin(), end(), push_back() and insert(), rather than listing specific classes by name
- Add serialize_adapter.h to support std::stack, std::queue and std::priority_queue adapter classes as a pass-through serialization of the underlying container
- Add serialize_tuple.h to support std::tuple and std::pair.

github-actions · 2025-03-23T07:33:28Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-03-23T07:33:32Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-03-23T07:54:00Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-03-23T23:38:15Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-03-23T23:38:24Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-03-23T23:50:06Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-03-24T11:12:00Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-03-24T11:12:04Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-03-24T11:20:15Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-03-24T12:46:30Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-03-24T12:46:40Z

CMAKE-FORMAT TEST - PASSED

kpgriesser · 2025-03-24T16:27:04Z

This change now requires the macro to have a semicolon.

/Users/kgriesser/work/sst-bench/sst-bench/large-stat-chkpnt/large-stat-chkpnt.cc:60:26: error: expected ';' after expression
   60 |     SST_SER(clockHandler)

If we want to keep it this way, which would be my preference as well, the documentation should also reflect this change:
https://sst-simulator.org/sst-docs/docs/guides/features/checkpoint

kpgriesser · 2025-03-24T17:12:23Z

@leekillough I am unable to compile sst-elements with these changes. Can you check on your side?

github-actions · 2025-03-28T23:42:45Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-03-28T23:42:47Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2025-03-31T08:00:53Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-03-31T08:01:00Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-03-31T08:21:07Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

sst-autotester · 2025-03-31T13:51:17Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

sst-autotester · 2025-03-31T13:57:53Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1909
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1865
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1864
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 838
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 691
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 645
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 432
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Build Num: 263
Status: STARTED

Using Repos:

Repo: CORE (leekillough/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: leekillough

sst-autotester · 2025-03-31T15:22:31Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1909
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1865
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1864
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 838
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 691
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 645
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 432
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Build Num: 263
Status: PASSED

sst-autotester · 2025-03-31T15:22:48Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

sst-autotester · 2025-03-31T15:22:55Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2025-03-31T20:47:26Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2025-04-01T02:02:25Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2025-04-01T06:20:55Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2025-04-01T10:20:59Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2025-04-01T14:21:05Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

feldergast

Looks good.

feldergast · 2025-04-01T15:25:37Z

src/sst/core/impl/interactive/simpleDebug.cc

@@ -71,7 +71,7 @@ SimpleDebugger::cmd_pwd(std::vector<std::string>& UNUSED(tokens))
 void
 SimpleDebugger::cmd_ls(std::vector<std::string>& UNUSED(tokens))
 {
-    std::vector<std::pair<std::string, SST::Core::Serialization::ObjectMap*>> vars = obj_->getVariables();
+    auto& vars = obj_->getVariables();


Shouldn't use auto here, but we can change it back in a future PR so we can get the majority of the changes merged.

sst-autotester · 2025-04-01T16:21:11Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ feldergast ]!

sst-autotester · 2025-04-01T16:21:18Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Mar 23, 2025

github-actions bot added the AT: CMAKE-FORMAT PASS label Mar 23, 2025

feldergast added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 23, 2025

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 23, 2025

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Mar 23, 2025

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Mar 24, 2025

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 24, 2025

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Mar 24, 2025

feldergast added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 24, 2025

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT FAIL labels Mar 28, 2025

feldergast added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 29, 2025

Reword comments; put break inside switch case block

866acc7

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 31, 2025

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Mar 31, 2025

feldergast added the AT: PRE-TEST INSPECTED label Mar 31, 2025

sst-autotester removed the AT: PRE-TEST INSPECTED label Mar 31, 2025

feldergast approved these changes Apr 1, 2025

View reviewed changes

feldergast merged commit 8cce3d5 into sstsimulator:devel Apr 1, 2025
7 checks passed

Generalize serialize to support more containers in a generalized way, and store mapping name in a stack stored in the serializer #1271

Generalize serialize to support more containers in a generalized way, and store mapping name in a stack stored in the serializer #1271

Conversation

leekillough commented Mar 23, 2025 • edited Loading

github-actions bot commented Mar 23, 2025

github-actions bot commented Mar 23, 2025

sst-autotester commented Mar 23, 2025

github-actions bot commented Mar 23, 2025

github-actions bot commented Mar 23, 2025

sst-autotester commented Mar 23, 2025

github-actions bot commented Mar 24, 2025

github-actions bot commented Mar 24, 2025

sst-autotester commented Mar 24, 2025

github-actions bot commented Mar 24, 2025

github-actions bot commented Mar 24, 2025

kpgriesser commented Mar 24, 2025 • edited Loading

kpgriesser commented Mar 24, 2025

github-actions bot commented Mar 28, 2025

github-actions bot commented Mar 28, 2025

github-actions bot commented Mar 31, 2025

github-actions bot commented Mar 31, 2025

sst-autotester commented Mar 31, 2025

sst-autotester commented Mar 31, 2025

sst-autotester commented Mar 31, 2025

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Using Repos:

sst-autotester commented Mar 31, 2025

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

sst-autotester commented Mar 31, 2025

sst-autotester commented Mar 31, 2025

sst-autotester commented Mar 31, 2025

sst-autotester commented Apr 1, 2025

sst-autotester commented Apr 1, 2025

sst-autotester commented Apr 1, 2025

sst-autotester commented Apr 1, 2025

feldergast left a comment

Choose a reason for hiding this comment

feldergast Apr 1, 2025

Choose a reason for hiding this comment

sst-autotester commented Apr 1, 2025

sst-autotester commented Apr 1, 2025

leekillough commented Mar 23, 2025 •

edited

Loading

kpgriesser commented Mar 24, 2025 •

edited

Loading