Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): events management #7

Merged
merged 31 commits into from
Jan 6, 2024
Merged

feat(admin): events management #7

merged 31 commits into from
Jan 6, 2024

Conversation

qin-guan
Copy link
Member

No description provided.

@qin-guan qin-guan mentioned this pull request Oct 18, 2023
app.config.ts Outdated
Comment on lines 5 to 7
notifications: {
position: 'bottom-0 left-0',
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this is included?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For configuring where the NuxtUI notifications will show

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, by default it doesn't show correctly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but shows on the bottom right. Saw it from the documentation that you can configure the rendering location by adding it there (https://ui.nuxt.com/overlays/notification)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Does this affect mobile? Or will it show bottom center on mobile?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll return bottom center on mobile

components/admin/event/event-checkedin-users.vue Outdated Show resolved Hide resolved
components/admin/event/event-checkedin-users.vue Outdated Show resolved Hide resolved
components/admin/event/event-checkedin-users.vue Outdated Show resolved Hide resolved
components/admin/event/event-information.vue Outdated Show resolved Hide resolved
composables/event.ts Outdated Show resolved Hide resolved
nuxt.config.ts Outdated Show resolved Hide resolved
pages/admin/event/[id].vue Outdated Show resolved Hide resolved
pages/index.vue Outdated Show resolved Hide resolved
server/api/event/index.post.ts Outdated Show resolved Hide resolved
@qin-guan
Copy link
Member Author

Good attempt @Ethan-Chew! I closed #3 in favor of this but let me know if you have something in that PR you want to merge into here. Left a few comments for your review 👍🏻

@qin-guan
Copy link
Member Author

Remember to lint your code (: !

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 14f3eb7
Status: ✅  Deploy successful!
Preview URL: https://770118c4.sstaa.pages.dev
Branch Preview URL: https://feat-nuxtui.sstaa.pages.dev

View logs

@qin-guan
Copy link
Member Author

qin-guan commented Jan 6, 2024

@Ethan-Chew want to help review then i'll merge in?

@qin-guan
Copy link
Member Author

qin-guan commented Jan 6, 2024

Related issue #10

@qin-guan qin-guan merged commit 2d019d2 into main Jan 6, 2024
2 of 3 checks passed
@qin-guan qin-guan deleted the feat/nuxtui branch January 6, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants