Implement Javascript Output Mode to Support SSH #238
+733
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitlangton
changed the title
Collaborator
|
The build failures are just some typescript type errors. I would just try to avoid copying the output buffer for every frame to avoid reallocations and the copy overhead by exposing pointers to the output buffers raw memory via lib.zig, connect them once with toArrayBuffer when setting up and then write out from that directly into buns buffered stdout. Other than that I love this and want to have that in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #187
I'll add more details later. This is to enable something like terminal.shop to be rewritten in opentui and be run via ssh (so teej can rewrite 😜).