Skip to content

Replace Assert.IsTrue with CollectionAssert.AreEqual for collection comparisons #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Replace Assert.IsTrue with CollectionAssert.AreEqual for collection comparisons #1730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb5ff67
Initial plan
Copilot Nov 4, 2025
17be689
Refactor collection assertions to use CollectionAssert.AreEqual
Copilot Nov 4, 2025
2821526
Fix argument order in CollectionAssert.AreEqual and remove unnecessar…
Copilot Nov 13, 2025
b8a5836
Merge remote-tracking branch 'upstream/develop' into copilot/refactor…
Rob-Hague Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/Renci.SshNet.Tests/Classes/AbstractionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
using Renci.SshNet.Abstractions;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using System;
using System;
using System.Threading;

using Microsoft.VisualStudio.TestTools.UnitTesting;

using Renci.SshNet.Abstractions;

namespace Renci.SshNet.Tests.Classes
{
[TestClass]
Expand Down
2 changes: 1 addition & 1 deletion ...sts/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseContainsNullCharacter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public void ClientIdentificationWasSentToServer()

Assert.HasCount(expected.Length + 2, _dataReceivedByServer);

Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
}
Expand Down
2 changes: 1 addition & 1 deletion ...VersionExchangeTest_ServerResponseInvalid_SshIdentificationOnlyContainsProtocolVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public void ClientIdentificationWasSentToServer()

Assert.HasCount(expected.Length + 2, _dataReceivedByServer);

Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
}
Expand Down
2 changes: 1 addition & 1 deletion ...hNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_Comments.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public void ClientIdentificationWasSentToServer()

Assert.HasCount(expected.Length + 2, _dataReceivedByServer);

Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
}
Expand Down
2 changes: 1 addition & 1 deletion ...lasses/Connection/ProtocolVersionExchangeTest_ServerResponseValid_EmptySoftwareVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public void ClientIdentificationWasSentToServer()

Assert.HasCount(expected.Length + 2, _dataReceivedByServer);

Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
}
Expand Down
2 changes: 1 addition & 1 deletion ...et.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_NoComments.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public void ClientIdentificationWasSentToServer()

Assert.HasCount(expected.Length + 2, _dataReceivedByServer);

Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
}
Expand Down
2 changes: 1 addition & 1 deletion ...tocolVersionExchangeTest_ServerResponseValid_TerminatedByLineFeedWithoutCarriageReturn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public void ClientIdentificationWasSentToServer()

Assert.HasCount(expected.Length + 2, _dataReceivedByServer);

Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
}
Expand Down
2 changes: 1 addition & 1 deletion ...ests/Classes/Connection/ProtocolVersionExchangeTest_TimeoutReadingIdentificationString.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public void ClientIdentificationWasSentToServer()

Assert.HasCount(expected.Length + 2, _dataReceivedByServer);

Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length)));
CollectionAssert.AreEqual(expected, _dataReceivedByServer.Take(expected.Length).ToArray());
Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]);
Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]);
}
Expand Down
3 changes: 1 addition & 2 deletions .../Renci.SshNet.Tests/Classes/Connection/Socks4ConnectorTest_Connect_ConnectionSucceeded.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Sockets;
using System.Threading;
Expand Down Expand Up @@ -129,7 +128,7 @@ public void ProxyShouldHaveReceivedExpectedSocksRequest()
PacketDump.Create(expectedSocksRequest, 2),
PacketDump.Create(_bytesReceivedByProxy, 2));

Assert.IsTrue(expectedSocksRequest.SequenceEqual(_bytesReceivedByProxy), errorText);
CollectionAssert.AreEqual(expectedSocksRequest, _bytesReceivedByProxy, errorText);
}

[TestMethod]
Expand Down
3 changes: 1 addition & 2 deletions ...ts/Classes/Connection/Socks5ConnectorTest_Connect_NoAuthentication_ConnectionSucceeded.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Sockets;
using System.Threading;
Expand Down Expand Up @@ -187,7 +186,7 @@ public void ProxyShouldHaveReceivedExpectedSocksRequest()
PacketDump.Create(expectedSocksRequest, 2),
PacketDump.Create(_bytesReceivedByProxy, 2));

Assert.IsTrue(expectedSocksRequest.SequenceEqual(_bytesReceivedByProxy), errorText);
CollectionAssert.AreEqual(expectedSocksRequest, _bytesReceivedByProxy, errorText);
}

[TestMethod]
Expand Down
3 changes: 1 addition & 2 deletions ...ection/Socks5ConnectorTest_Connect_UserNamePasswordAuthentication_AuthenticationFailed.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Sockets;
using System.Text;
Expand Down Expand Up @@ -145,7 +144,7 @@ public void ProxyShouldHaveReceivedExpectedSocksRequest()
PacketDump.Create(expectedSocksRequest, 2),
PacketDump.Create(_bytesReceivedByProxy, 2));

Assert.IsTrue(expectedSocksRequest.SequenceEqual(_bytesReceivedByProxy), errorText);
CollectionAssert.AreEqual(expectedSocksRequest, _bytesReceivedByProxy, errorText);
}

[TestMethod]
Expand Down
3 changes: 1 addition & 2 deletions ...nection/Socks5ConnectorTest_Connect_UserNamePasswordAuthentication_ConnectionSucceeded.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Sockets;
using System.Text;
Expand Down Expand Up @@ -201,7 +200,7 @@ public void ProxyShouldHaveReceivedExpectedSocksRequest()
PacketDump.Create(expectedSocksRequest, 2),
PacketDump.Create(_bytesReceivedByProxy, 2));

Assert.IsTrue(expectedSocksRequest.SequenceEqual(_bytesReceivedByProxy), errorText);
CollectionAssert.AreEqual(expectedSocksRequest, _bytesReceivedByProxy, errorText);
}

[TestMethod]
Expand Down
3 changes: 1 addition & 2 deletions ...ocks5ConnectorTest_Connect_UserNamePasswordAuthentication_PasswordExceedsMaximumLength.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Sockets;
using System.Threading;
Expand Down Expand Up @@ -117,7 +116,7 @@ public void ProxyShouldHaveReceivedExpectedSocksRequest()
PacketDump.Create(expectedSocksRequest, 2),
PacketDump.Create(_bytesReceivedByProxy, 2));

Assert.IsTrue(expectedSocksRequest.SequenceEqual(_bytesReceivedByProxy), errorText);
CollectionAssert.AreEqual(expectedSocksRequest, _bytesReceivedByProxy, errorText);
}

[TestMethod]
Expand Down
3 changes: 1 addition & 2 deletions ...ocks5ConnectorTest_Connect_UserNamePasswordAuthentication_UserNameExceedsMaximumLength.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Sockets;
using System.Threading;
Expand Down Expand Up @@ -115,7 +114,7 @@ public void ProxyShouldHaveReceivedExpectedSocksRequest()
PacketDump.Create(expectedSocksRequest, 2),
PacketDump.Create(_bytesReceivedByProxy, 2));

Assert.IsTrue(expectedSocksRequest.SequenceEqual(_bytesReceivedByProxy), errorText);
CollectionAssert.AreEqual(expectedSocksRequest, _bytesReceivedByProxy, errorText);
}

[TestMethod]
Expand Down
2 changes: 1 addition & 1 deletion test/Renci.SshNet.Tests/Classes/Messages/Connection/ChannelDataMessageTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public void GetBytes()

var actualData = new byte[size];
_ = sshDataStream.Read(actualData, 0, size);
Assert.IsTrue(actualData.SequenceEqual(data.Take(offset, size)));
CollectionAssert.AreEqual(data.Take(offset, size), actualData);

Assert.IsTrue(sshDataStream.IsEndOfData);
}
Expand Down
5 changes: 2 additions & 3 deletions test/Renci.SshNet.Tests/Classes/Messages/Connection/ChannelOpen/ChannelOpenMessageTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System.Globalization;
using System.Linq;
using System.Text;

using Microsoft.VisualStudio.TestTools.UnitTesting;
Expand Down Expand Up @@ -103,15 +102,15 @@ public void GetBytes()

var actualChannelType = new byte[actualChannelTypeLength];
_ = sshDataStream.Read(actualChannelType, 0, (int)actualChannelTypeLength);
Assert.IsTrue(target.ChannelType.SequenceEqual(actualChannelType));
CollectionAssert.AreEqual(target.ChannelType, actualChannelType);

Assert.AreEqual(localChannelNumber, sshDataStream.ReadUInt32());
Assert.AreEqual(initialWindowSize, sshDataStream.ReadUInt32());
Assert.AreEqual(maximumPacketSize, sshDataStream.ReadUInt32());

var actualInfo = new byte[infoBytes.Length];
_ = sshDataStream.Read(actualInfo, 0, actualInfo.Length);
Assert.IsTrue(infoBytes.SequenceEqual(actualInfo));
CollectionAssert.AreEqual(infoBytes, actualInfo);

Assert.IsTrue(sshDataStream.IsEndOfData);
}
Expand Down
3 changes: 1 addition & 2 deletions test/Renci.SshNet.Tests/Classes/Messages/Transport/IgnoreMessageTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System;
using System.Linq;

using Microsoft.VisualStudio.TestTools.UnitTesting;

Expand Down Expand Up @@ -75,7 +74,7 @@ public void GetBytes()

var actualData = new byte[_data.Length];
_ = sshDataStream.Read(actualData, 0, actualData.Length);
Assert.IsTrue(_data.SequenceEqual(actualData));
CollectionAssert.AreEqual(_data, actualData);

Assert.IsTrue(sshDataStream.IsEndOfData);
}
Expand Down
Loading
Loading