Skip to content

Possibility not to specify BoundHost when using ForwardedPortRemote #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Possibility not to specify BoundHost when using ForwardedPortRemote #1234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/Renci.SshNet/ForwardedPortRemote.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public string BoundHost
{
get
{
return BoundHostAddress.ToString();
return BoundHostAddress?.ToString() ?? string.Empty;
}
}

Expand Down Expand Up @@ -86,11 +86,6 @@ public string Host
/// <exception cref="ArgumentOutOfRangeException"><paramref name="port" /> is greater than <see cref="IPEndPoint.MaxPort" />.</exception>
public ForwardedPortRemote(IPAddress boundHostAddress, uint boundPort, IPAddress hostAddress, uint port)
{
if (boundHostAddress is null)
{
throw new ArgumentNullException(nameof(boundHostAddress));
}

if (hostAddress is null)
{
throw new ArgumentNullException(nameof(hostAddress));
Expand All @@ -116,7 +111,7 @@ public ForwardedPortRemote(IPAddress boundHostAddress, uint boundPort, IPAddress
/// <code source="..\..\src\Renci.SshNet.Tests\Classes\ForwardedPortRemoteTest.cs" region="Example SshClient AddForwardedPort Start Stop ForwardedPortRemote" language="C#" title="Remote port forwarding" />
/// </example>
public ForwardedPortRemote(uint boundPort, string host, uint port)
: this(string.Empty, boundPort, host, port)
: this(boundHost: null, boundPort, host, port)
{
}

Expand All @@ -128,7 +123,7 @@ public ForwardedPortRemote(uint boundPort, string host, uint port)
/// <param name="host">The host.</param>
/// <param name="port">The port.</param>
public ForwardedPortRemote(string boundHost, uint boundPort, string host, uint port)
: this(DnsAbstraction.GetHostAddresses(boundHost)[0],
: this(boundHost == null ? null : DnsAbstraction.GetHostAddresses(boundHost)[0],
Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direct array indexing without bounds checking could throw IndexOutOfRangeException if GetHostAddresses returns an empty array. Consider adding validation to ensure the array is not empty before accessing the first element.

Copilot uses AI. Check for mistakes.

boundPort,
DnsAbstraction.GetHostAddresses(host)[0],
port)
Expand Down