Fixes and improvements for port forwarding tests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add intermittend output test for ShellStream.
|
Can you please push updated TestTools? PrintMotd and AllowTcpForwarding are missing in SshdConfig. |
Done |
IgorMilavec
reviewed
Mar 28, 2022
| @@ -642,7 +661,7 @@ public void Ssh_RemotePortForwarding() | |||
| using (var s = client.CreateShellStream("a", 80, 25, 800, 600, 200)) | |||
| { | |||
| s.WriteLine($"telnet {forwardedPort1.BoundHost} {forwardedPort1.BoundPort}"); | |||
| s.Expect("Escape character is '^]'."); | |||
| s.Expect($"Connected to {forwardedPort1.BoundHost}\r\n"); | |||
There was a problem hiding this comment.
The tests hang here. Expect() should be called with timeout (5 seconds should do it).
There was a problem hiding this comment.
We have a different issue open for this, so maybe we should leave this for later.
This PR definitely improved stability, so I think you can merge it.
IgorMilavec
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SftpClient.Open(...).