Allow entering larger values in sliders and spinboxes than current min-max#448
Allow entering larger values in sliders and spinboxes than current min-max#448ameraner merged 15 commits intossec:masterfrom
Conversation
|
Hello Andrea @ameraner , so I have checked this PR and I think it is ready to be handed over to you 🙂 I would like to remove the "DRAFT" label but I lack the rights and Ana is not available today. Maybe you could do that? Previously the Coverall failed again since the code updated is QT widget code which has not been provided with unit tests beforehand. And since we mostly do not have tests for GUI logic from what I see (e.g. _test_rgb_config is disabled) I added Is that ok with you? |
|
Hi @RudiLauster and @AnaVukasinovic , thank you for this! maybe it's a OS specific behaviour? I'm testing it on linux... Could you please take a look what could be the issue? |
|
Regarding the tests: I deactivated them temporarily in #437 and want to reactivate them asap in #439 - I did this since due to an unknown issue they were failing in the CI (but not locally), so in order to be able to run the tests on our new PRs successfully in the CI I turned them off temporarily. |
|
Hello Andrea @ameraner, So, for testing the QT-test issue I enabled the test_rgb_config to see what goes wrong. As discussed this test would serve to cover the changes applied for rgb_config. |
|
Hi Andrea @ameraner |
|
Merged as part of #452 |
This bugfix allows the sliders and spinboxes in Layer Details, including the RGB sliders, to no longer have fixed minimum and maximum values. Users can now input arbitrary values into the spinbox or edit box. If the entered value exceeds the current maximum or is below the current minimum, the limits are updated accordingly, and the sliders adjust to reflect the new range.
Closes #394