Support **$... for keyword arguments.
#102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
copybara_568317030
branch
from
5e56d9b to
311a231
Compare
This pretty much just works out of the box, albeit it's ordering-dependent.
For instance, to match any call to `foo.Bar` which does _not_ include `dry_run=True`, you can use:
```python
AllOf(
ExprPattern("foo.Bar(*$..., **$...)"),
Unless(ExprPattern("$_(*$..., **$..., dry_run=True, **$...)"))
)
```
Or similar.
A future change to refex (which I do want to make eventually...) could eventually mean keyword parameter and dict ordering is ignored by default, so that we can remove one of the `**$...`.
PiperOrigin-RevId: 568317030
copybara-service
bot
force-pushed
the
copybara_568317030
branch
from
311a231 to
5623a87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
**$...for keyword arguments.This pretty much just works out of the box, albeit it's ordering-dependent.
For instance, to match any call to
foo.Barwhich does not includedry_run=True, you can use:Or similar.
A future change to refex (which I do want to make eventually...) could eventually mean keyword parameter and dict ordering is ignored by default, so that we can remove one of the
**$....