Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Padding to Content to Show Last Item #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcastre
Copy link

@mcastre mcastre commented Oct 5, 2017

  • With the height of the sth-select-content being managed by jquery, the panel needs to recompensate for the remaining 50px. Adding a padding-bottom of 50px fixes the issue and also will not affect the list if the list is longer than the example provides. Hope you like!

@StanleySathler
Copy link
Member

StanleySathler commented Oct 7, 2017

Hello @mcastre
Great commit, bro! You notice a good point.

The point is that, as you said, the content's height is managed by jQuery. The problem, in fact, occurs because, when there is filter available, the content's height ignores it and calculates its size in a wrong way.

Your solution works good when the popup has a filter, but doesn't work so well when there is no filter. In this case, we have an empty space in the bottom.

screen shot 2017-10-07 at 12 58 01

In this case, there's a better solution which is in the JavaScript code directly. But if you don't mind, you and @coderwassananmol worked on the same bug fix, but the bug was reported by him. Would you mind if I give him the preference? I'd like to be fair enough.

@mcastre
Copy link
Author

mcastre commented Oct 10, 2017

@StanleySathler thats no problem at all! I did have a question however. If there are no filters, would it be wise to even allow the popup to display? Wouldn't it just display an empty popup?

@StanleySathler
Copy link
Member

Helloooo @mcastre

I'm really, really sorry about taking too long to answer you. I didn't see this message in my notifications list before.

I'm not sure if I understood your question correctly, so let me know if I'm not answering exactly what you asked.

But as far as I know, when there is no filter - that is, the filter field is empty - all items are shown in the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants