Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dependencies to wait for P/PE/CE nodes before starting the server #33

Closed
wants to merge 1 commit into from

Conversation

hellt
Copy link
Member

@hellt hellt commented Mar 6, 2024

@tiago-amado @mairp @alfilipe

this is a hotfix to make this lab compatible with clab 0.52+

I shared the details with @alfilipe, the culprit is that the web app doesn't handle network unreachable nodes when trying to fetch the port status with gnmi.

In this PR I used the stages dependency to ensure that the client7 node executes its setup in the configure stage after all routers are rendered healthy. This makes the ports reachable by the time the flask app starts.

@hellt hellt marked this pull request as draft March 6, 2024 12:48
@mairp
Copy link
Member

mairp commented Mar 6, 2024

hi @hellt excellence!, actually this is a really good example of how to use stages on clab, please let us know when this is ready.

@hellt
Copy link
Member Author

hellt commented Mar 6, 2024

this is ready, but it would be best if @alfilipe fixes the flask app not to error on unavailable connections

so maybe let's see if he can come up with a solution in a couple of days and if not, we can merge this and say that clab 0.52.0 is the min required version

@hellt
Copy link
Member Author

hellt commented Jul 25, 2024

superseded by #38

@hellt hellt closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants