Fix og:image path to be absolute #537
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
cc @shivaraj-bh |
srid
reviewed
Jul 1, 2024
Owner
srid
left a comment
srid
left a comment
There was a problem hiding this comment.
I'm not entirely sure about this change. Been a while since I worked on Emanote, but IIRC link and image URLs are not always considered relative.
In any case, we need to tests before being able to make changes like this.
TristanCacqueray
added a commit
to TristanCacqueray/tristancacqueray.github.io
that referenced
this pull request
Jul 1, 2024
Contributor
Author
You are absolutely right, let me convert this to a draft. There are other papercuts in the |
This change resolves the relative note image path to make an absolute url. For `blog/post.md` with a ``, the og:image is: - Before: `siteUrl/media/image.png` - After: `siteUrl/blog/media/image.png`
TristanCacqueray
force-pushed
the
absolute-og-img
branch
from
74ae0f8 to
ceb9ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves the relative note image path to make an absolute url.
For
blog/post.mdwith a, the og:image is:siteUrl/media/image.pngsiteUrl/blog/media/image.png