Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webapp - wsl shell source not found #155

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

Sayvai
Copy link
Contributor

@Sayvai Sayvai commented Sep 23, 2023

fix: webapp - WSL Ubuntu shell source not found

A bug was found (see GitHub Issue #153), where when a user attempting to run the npm run dev or npm run fastapi-dev commands from within a (Windows) WSL Ubunutu Shell window, encounters the following error, which prevents the backend FastAPI server from running:

sh: 1: source: not found

Given it appears that source is a command built-in and runnable on Bash and ZSH terminal environments, it is not available to use within the WSL Ubuntu shell by default.

To fix this, a more universal substitute can be used in place of source, which is the period ., which performs the same function in Bash, ZSH, and WSL Ubunutu terminal / shell environments.

This commit also includes minor webapp/README.md updates to reformat lists to numbered lists for both the Setup and Debugging sections for improved clarity.

Related Issue

Description

  • Updated webapp/package.json file to run source commands with the period. Replacing source with ..
  • Updated webapp/README.md to apply minor reformatting changes to lists on both the Setup and Debugging sections.

Type

  • Bug Fix
  • Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify):

Proposed Changes

  • webapp/package.json
  • webapp/README.md

Screenshots / Code Snippets (if applicable)

N/A

How to Test

N/A

Checklist

  • The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • [ X This pull request has been linked to the related issue (if applicable)

Additional Information

N/A

A bug was found (see GitHub Issue srbhr#153), where when a user attempting to run the `npm run dev` or `npm run fastapi-dev` commands from within a (Windows) WSL Ubunutu Shell window, encounters the following error, which prevents the backend FastAPI server from running:

`sh: 1: source: not found`

Given it appears that `source` is a command built-in and runnable on Bash and ZSH terminal environments, it is not available to use within the WSL Ubuntu shell by default.

To fix this, a more universal substitute can be used in place of `source`, which is the period `.`, which performs the same function in Bash, ZSH, and WSL Ubunutu terminal / shell environments.

This commit also includes minor `webapp/README.md` updates to reformat lists to numbered lists for both the `Setup` and `Debugging` sections for improved clarity.
@srbhr srbhr merged commit e49b3e6 into srbhr:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants