Skip to content

Swarm and Nomad support #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 65 commits into
base: interactive_repair
Choose a base branch
from
Open

Swarm and Nomad support #62

wants to merge 65 commits into from

Conversation

sfondev
Copy link

@sfondev sfondev commented Apr 10, 2025

PR that will contain all the changes for supporting Docker Swarm and HashiCorp Nomad

@sfondev sfondev closed this Apr 11, 2025
@sfondev sfondev force-pushed the swarm-and-nomad-parsers branch from b21f323 to a08797f Compare April 11, 2025 22:54
@sfondev sfondev reopened this Apr 11, 2025
Nfsaavedra
Nfsaavedra reviewed Apr 17, 2025
View reviewed changes
sfondev added 22 commits April 25, 2025 14:52
@sfondev
format swarm.py
4c0178c
@sfondev
change Terraform parser get_element_info method visibility to protect…
10dd8e6 
…ed so it can be accessible to subclasses
@sfondev
changed the Transformer for Nomad to be a new class that extends the …
602191f 
…GLITCHTransformer used in the Terraform parser
@sfondev
format nomad.py
0adf8ae
@sfondev
format nomad.py and fix missing abs file path issue
f5089f4
@sfondev
fixes swarm.py adds support for 'extends' and 'includes' extension
759ff54
@sfondev
fix docker_images_scraper.py: add support for the new search api and …
899368c 
…add new filtering for official images that are deprecated
@sfondev
remove forgotten print 😅
9680335
@sfondev
fix boolean parsing
7031412
@sfondev
swarm and nomad tech introduction
c32defa
@sfondev
fix add more common tar compressed with bzip2 extension, also for zst…
4cd8574 
…d compressed tar
@sfondev
adding the smells error messages
602602b
@sfondev
swarm and nomad parsers fixes
808439c
@sfondev
correctly escape the '%' character for copying into latex
4d2fbd9
@sfondev
adding implementation of Log Collection and some of container image s…
5c67131 
…mells, re-enable detection of weak crypto and https missing smells
@sfondev
add deprecated official images smell
253dc45
@sfondev
added files needed for log collector/log aggregator smell
e178edc
@sfondev
currently useless file, will remove later
7ad6a8d
@sfondev
currently useless file, will remove later
d7177d4
@sfondev
added file needed for the unstable image smell
1e19b3d
@sfondev
adding no api gateway smell files
3a49007
@sfondev
adding priveleged containers, mounted docker socket and Nomad integri…
94712dc 
…ty check smells
@sfondev
Copy link
Author

sfondev commented Aug 25, 2025 •
edited
Loading

I added some comments but what concerns be the most is the lack of added tests. Do you have tests for the parsers and for the new smells?

When I was coding the parsers I was mostly testing with example files from the web I found to be more or less "complex" and that had the attributes needed to do the detection. I tested by running the parser on them until parsing all the information needed and they didn't error out.
Indeed unfortunately the parsers aren't robust for real world usage, since when running GLITCH on the whole datasets they do end up error out on some of the files. However, in that case some of the errors are really not the parsers fault, since they happen due to files that aren't really valid Compose/Swarm files or Nomad.
But creating or choosing test files, for the smells should be doable.

@Nfsaavedra
Copy link
Member

It is OK if some the parsers are not able to parse some files. The same happens for the other technologies

sfondev added 20 commits August 28, 2025 13:33
@sfondev
fix matching invalid ip bindings in complete command invocations, by …
ae48806 
…spliting the args
@sfondev
fix typo
0ade21c
@sfondev
remove hack, fix variable parsing in swarm
f8ce625
@sfondev
change to use StringChecker and add handling of arrays and hashes
7ceb362
@sfondev
fix empty strings in env var value
365c906
@sfondev
fix some of SecurityVisitor global constants not being initialized fo…
aef512b 
…r all the techs (as some of the smell detectors that use them were 'made available' to all other techs)
@sfondev
add: swarm tests
f1ccef5
@sfondev
add missing __init__.py needed for test detection
578bb59
@sfondev
fix filenames of official docker images and deprecated official image…
9d12ba3 
…s in scraper script
@sfondev
update official docker images list
e6150d4
@sfondev
remove unnecessary method
cb0e621
@sfondev
remove unused import
200e9dc
@sfondev
fix: consider both list of official images. The newer list of officia…
febd84d 
…l images (maintained) doesn't include the ones in the deprecated official images one
@sfondev
format visitor.py
374c39f
@sfondev
fix missing healthchecks smell and wobbly service interaction on nomad
8a5f19e
@sfondev
add nomad tests
fa902f5
@sfondev
fix: add hack to avoid using detection function tailored to nomad for…
4ee287e 
… swarm detections
@sfondev
fix name of nomad task config logging driver attribute
9835c68
@sfondev
hack: support multiple artifacts missing integrity checks in Nomad
7caa60e
@sfondev
fix: pinned container image without digest smell
6d9cad3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nfsaavedra Nfsaavedra Nfsaavedra requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sfondev @Nfsaavedra