Optional model parameter to bypass discovery #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this PR? |
|
hello @squishykid , is there anything else you need to review and merge this in? |
Merged
|
This PR can probably be closed since #145 has been merged. |
|
closing because a better fix was merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another solution to the problem described here:
home-assistant/core#66617
The other solution is in #138 and is slightly more complicated because it introduces a new entrypoint to the library.
The solution here was originally implemented in #133 by @rowinho
then modified to pass tests by @luismsousa
My modification is in the test suite to make sure coverage is 100%.
I could not modify directly one of the previous PRs, so this is yet another PR. This one passes all tests on python 3.8/3.9/3.10 on my mac.