Skip to content

Commit

Permalink
fix(launch): prevent freeze on many log messages
Browse files Browse the repository at this point in the history
The 1.88 preview added lots of useful log messages. However, these were
filling the output buffer when running `nasher test` or `nasher play`,
causing the game to freeze. Redirecting the logging to nasher's output
fixes the issue. However, this does result in lots of logging messages
going to nasher, which may be undesirable.
  • Loading branch information
squattingmonk committed May 9, 2024
1 parent b78c593 commit 89b00ef
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/nasher/launch.nim
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ proc launch*(opts: Options, target: Target) =

var
path, args: string
options = {poStdErrToStdOut}
options = {poStdErrToStdOut, poParentStreams}

case cmd
of "play":
Expand All @@ -59,7 +59,6 @@ proc launch*(opts: Options, target: Target) =
of "serve":
path = opts.get("serverBin", getServerBin())
args = "-module"
options.incl(poParentStreams)
else:
assert false

Expand Down

0 comments on commit 89b00ef

Please sign in to comment.