DNM: Temp for Snapshot #1361
Open
DNM: Temp for Snapshot #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows users to freely zoom and pan to view different sections of the tree
The attributes of each node is tightly coupled with the content of the json, so any changes to the JSON will lead to an error unless the WorkflowNode class is also changed accordingly.
…ow node - arrows start with a weird offset in the beginning relative to where the nodes are
…Snapshot Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- if modifier is set to unbounded, content also needs to be aligned.
- Density of displays caused weird errors of how the arrows appear - Scaling and translating the arrow positions was also separate from the movement of the nodes
- Figuring out how to lay out arrows was unnecessarily difficult, and ended up being too distracting, so utilizing the column space each node and its children are in was a much cleaner way to represent a subtree relationship - Figure will closely resemble a treemap
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- This will provide a lot more information about each workflow node that's clicked, especially when it could contain a lot of information
The order of the main content being displayed was from parsing -> rendering, which would lead to complexity when adding in tabbing functionality. Having the order be Renderer -> parsing -> rendering was more clear. This commit also introduces the idea of a "trace", where we have input a json array instead of a singular json
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1. Made terminology and variable naming consistent (see README changes) 2. Fixed caught bugs in PR review 3. Right aligned inspection tab
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1. Clarified component positions with modifiers 2. Removed unnecessary comments 3. Simplified JsonParser
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Deletes bit about avoiding tutorial updates.
Simplifies creating a `WorkflowLayout` and using it as the `contentView` of an `Activity`. Written with an eye toward making it easy to hand off from one workflow runtime to another, or doing something like `activity.workflowContentView.show(LoadingScreen)` before any workflow runtime is put in place. Nice for testing too.
Uses `Throwable.withKey` in a few more choke points, to break up crash reporter kitchen sinks. Had to make a few `internal` core methods public to allow their use from the android modules, but I think that's okay -- they're still in a package named `internal`, our intent should be clear.
Demonstrates and documents the preferred pattern of keeping Composable functions as static as possible, and fixes a few stray doc spots where `WorkflowRendering` was still being called with its `ViewEnvironment` parameter.
…ntime If it is not being used on Android, use it for the runtime whenever on Android (requiring Compose)
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
steve-the-edwards
force-pushed
the
sedwards/snapshot-dea
branch
from
383e205 to
afc6bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.