Unsigned numbers in Okio

[bnorm]

Fixes #513

[bnorm]

Do we want to have our own experimental annotation or pass through the ExperimentalUnsignedTypes annotation?

On one hand it would be nice to have our own annotation so we don't have to become non-experimental when unsigned types do, but on the other I don't see this API changing much. I'm leaning towards removing OkioUnsignedApi, let me know if you want me to keep it.

[JakeWharton]

I would pass it through the original because we're using their types in the public API. If we were using them as implementation detail only I would prefer our own annotation.

[swankjesse]

The annotation is the most interesting part of this. I think my preference is to publish this as a gist or sample until unsigned types are stable.

[bnorm]

I would be fine with either a sample or gist. I think I would lean to a sample as it will force us to update it if unsigned types ever change and might make it easier to find.

[swankjesse]

Good call. Make is so!

[bnorm]

Old version didn't like unsigned literals in the samples project. Not sure why it was okay before.

[swankjesse]

@bnorm sorry for sitting on this!

[swankjesse]

Still waiting on unsigned types?

[ImUrX]

😭

[ImUrX]

whats missing from this? it would really nice to have it!

[MohammadKHC]

@swankjesse @JakeWharton

I see that this is already approved. Can it get merged?

Having unsigned functions will remove the need for all this masking

okio/okio/src/zlibMain/kotlin/okio/internal/ZipFiles.kt

Lines 198 to 216 in 9fbab0f

	val bitFlag = readShortLe().toInt() and 0xffff
	if (bitFlag and BIT_FLAG_UNSUPPORTED_MASK != 0) {
	throw IOException("unsupported zip: general purpose bit flag=${bitFlag.hex}")
	}
	val compressionMethod = readShortLe().toInt() and 0xffff
	val dosLastModifiedTime = readShortLe().toInt() and 0xffff
	val dosLastModifiedDate = readShortLe().toInt() and 0xffff
	// These are 32-bit values in the file, but 64-bit fields in this object.
	val crc = readIntLe().toLong() and 0xffffffffL
	var compressedSize = readIntLe().toLong() and 0xffffffffL
	var size = readIntLe().toLong() and 0xffffffffL
	val nameSize = readShortLe().toInt() and 0xffff
	val extraSize = readShortLe().toInt() and 0xffff
	val commentByteCount = readShortLe().toInt() and 0xffff
	skip(8) // disk number start (2) + internal file attributes (2) + external file attributes (4).
	var offset = readIntLe().toLong() and 0xffffffffL

For example instead of readShortLe().toInt() and 0xffff it could just be readUShortLe() right?

And it will generally make me happy when parsing files that store unsigned Integers.

[JakeWharton]

Note that this PR:

• Is very old and thus uses the now outdated experimental annotation.
• Is only for the JVM rather than common.
• Has its sources in a sample not the main artifact.
• Lacks the array-based unsigned types (probably because they didn't exist yet at the time).

So no, we cannot merge the PR as-is. I'm going to close it. However, I think we're ready to merge functions like these into the correct place now.