Skip to content

Improve error message when headers exceed 256 KiB limit #9259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
one-kash wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

Improve error message when headers exceed 256 KiB limit #9259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion okhttp/src/commonJvmAndroid/kotlin/okhttp3/internal/http1/HeadersReader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*/
package okhttp3.internal.http1

import java.io.EOFException
import java.net.ProtocolException
import okhttp3.Headers
import okio.BufferedSource

Expand All @@ -28,7 +30,15 @@ class HeadersReader(

/** Read a single line counted against the header size limit. */
fun readLine(): String {
val line = source.readUtf8LineStrict(headerLimit)
val line =
try {
source.readUtf8LineStrict(headerLimit)
} catch (e: EOFException) {
throw ProtocolException(
"Header line limit exceeded (${HEADER_LIMIT / 1024} KiB). " +
"The response headers are too large.",
).initCause(e)
}
headerLimit -= line.length.toLong()
return line
}
Expand Down
Loading