Implement Phase 1: Complete SELECT statement support #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive SELECT parsing with the following features: - TOP clause with PERCENT and WITH TIES options - SELECT INTO for table creation - WHERE, GROUP BY, HAVING clauses - ORDER BY clause with ASC/DESC - UNION, EXCEPT, INTERSECT set operations - JOIN support (INNER, LEFT/RIGHT/FULL OUTER, CROSS) - ODBC literal syntax for guid, date, time, timestamp - Empty schema identifier handling (db..table syntax) New AST types: - TopRowFilter for TOP clause - NumericLiteral for decimal numbers - QueryParenthesisExpression for parenthesized subqueries - BinaryQueryExpression for UNION/EXCEPT/INTERSECT - UnqualifiedJoin for CROSS JOIN - OdbcLiteral for ODBC escape sequences Added ~25 new lexer tokens and updated JSON serialization to match Microsoft SqlScriptDOM output format. SelectStatementTests now passes (unskipped).
Add comprehensive T-SQL parser support for: - Expression types: NULL, DEFAULT, UnaryExpression - DML statements: INSERT, UPDATE, DELETE - DDL statements: CREATE TABLE, CREATE VIEW, CREATE SCHEMA, GRANT - Control flow: DECLARE, IF, WHILE, BEGIN/END, BREAK, CONTINUE, RETURN - SET statements: PredicateSetStatement (ANSI_NULLS, etc.) - EXECUTE statements with procedure references New AST types (26 files): - begin_end_block_statement.go, break_statement.go, continue_statement.go - create_schema_statement.go, create_table_statement.go, create_view_statement.go - declare_variable_statement.go, delete_statement.go, execute_statement.go - grant_statement.go, if_statement.go, insert_statement.go - predicate_set_statement.go, return_statement.go, set_variable_statement.go - update_statement.go, while_statement.go - null_literal.go, default_literal.go, unary_expression.go - cursor_id.go, internal_open_rowset.go, literal_optimizer_hint.go - schema_object_function_table_reference.go, table_hint.go - variable_table_reference.go Lexer additions (8 new token types): - Security keywords: GRANT, REVOKE, TO, PUBLIC Parser enhancements (~3000 lines): - Parsing functions for all new statement types - JSON serialization for AST output - Proper $ref handling for duplicate identifiers Passing tests: BeginEndBlockStatementTests, CreateSchemaStatementTests, DeclareVariableStatementTests, IfStatementTests, SelectStatementTests, and more existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive SELECT parsing with the following features:
New AST types:
Added ~25 new lexer tokens and updated JSON serialization
to match Microsoft SqlScriptDOM output format.
SelectStatementTests now passes (unskipped).