Replace test cases with all 6823 queries from ClickHouse stateless tests #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced custom test cases with queries directly from the ClickHouse repository's tests/queries/0_stateless folder. Each test directory is now named to match the original ClickHouse test file (e.g., 00007_array). All tests are marked as todo until parser support is implemented.
- Generated ast.json for all 6823 test queries using ClickHouse EXPLAIN AST - Removed ast/explain.go and ast/explain_test.go (no longer needed) - Updated parser_test.go to use ast.json for expected AST comparison - Tests now skip queries that ClickHouse also failed to parse
- Updated parser_test.go to parse only first line of query.sql (matches how ast.json was generated) - Fixed empty ast.json files by marking them as error: true - Tests now complete in ~4 seconds instead of timing out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced custom test cases with queries directly from the ClickHouse
repository's tests/queries/0_stateless folder. Each test directory is
now named to match the original ClickHouse test file (e.g., 00007_array).
All tests are marked as todo until parser support is implemented.