Replace comment preservation with simple comment stripping for format tests #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests Instead of adding complex comment handling to the AST (Comment struct, StatementWithComments wrapper), use a simple comment-stripping function in the test to normalize expected output. This approach: - Removes 57 lines from ast/ast.go (Comment, StatementWithComments) - Simplifies the parser by just skipping comments instead of tracking them - Removes comment formatting code from the format package - Adds a simple stripComments() function in tests for expected output normalization The format tests now compare the formatted output against the original query with comments stripped, which is simpler and achieves the same goal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding complex comment handling to the AST (Comment struct,
StatementWithComments wrapper), use a simple comment-stripping function
in the test to normalize expected output. This approach:
The format tests now compare the formatted output against the original
query with comments stripped, which is simpler and achieves the same goal.