Add -check-skipped flag to identify passing todo tests #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a -check-skipped flag to the test suite that runs tests marked with todo:true instead of skipping them. This makes it easy to see which previously-skipped tests now pass and can have their todo flag removed. Usage: go test ./parser -check-skipped -v Tests that pass show "PASSES NOW - can remove todo flag from: <name>" Tests that fail show "STILL FAILING (<reason>): <details>"
After adding the -check-skipped flag, identified 328 tests that were marked as todo but now pass all checks. Removed the todo flag from their metadata.json files (deleted the file entirely if todo was the only field). Also updated CLAUDE.md to document the -check-skipped workflow for identifying passing skipped tests after parser fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a -check-skipped flag to the test suite that runs tests marked
with todo:true instead of skipping them. This makes it easy to see
which previously-skipped tests now pass and can have their todo flag
removed.
Usage: go test ./parser -check-skipped -v
Tests that pass show "PASSES NOW - can remove todo flag from: "
Tests that fail show "STILL FAILING ():
Details
"