Quote mysql.exe calls on Windows correctly because IPC::S::S doesn't. #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run() here calls IPC::S::S' runx(), which has two paths. On non-windows
systems it calls `system { $command } $command, @args` which works just
fine even with complex stuff in the args. On Windows however it calls
`_spawn_or_die($command, "$command @Args")`, which smashes all the
arguments together separated by spaces without *any* additional quoting.
This results in a garbage process call which mysql consequently rewards
with RTFM.
This fix quotes the arguments on windows, and takes care to leave the
executable name separate to allow proper naming of the created process
object.
fixes sqitchers#262
Collaborator
|
I'm torn about this. I intentionally didn't make this change because I was optimistic that pjf/ipc-system-simple#29 would get merged and released. Perhaps too optimistic. :-( Perhaps we should try to figure proof it to only quote the words if the version is |
Author
|
I have absolutely no preference for this at the moment. sqitch is simply broken on windows. Unusuable. No good. Any action is better than no action. |
Collaborator
|
Okay, done in 0148359. |
Author
|
Looks excellent! 👍 |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run() here calls IPC::S::S' runx(), which has two paths. On non-windows systems it calls
system { $command } $command, @argswhich works just fine even with complex stuff in the args. On Windows however it calls_spawn_or_die($command, "$command @args"), which smashes all the arguments together separated by spaces without any additional quoting. This results in a garbage process call which mysql consequently rewards with RTFM.This fix quotes the arguments on windows, and takes care to leave the executable name separate to allow proper naming of the created process object.
fixes #262