PR: Compatibility fixes for Spyder 6.0.0 alpha 5 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a side-effect of PR spyder-ide/spyder#21734, a QApplication needs to be running before importing spyder.plugins.preferences.widgets.configdialog. Moving the import inside a function achieves this.
This was introduced in PR spyder-ide/spyder#21353
This mirrors the changes in PR spyder-ide/spyder#21353
It is not clear why this is needed, but without this the tests abort on exit with "QThread: Destroyed while thread is still running"
This follows the new API after PR spyder-ide/spyder#21844.
* This is to get Node 20 because older versions are deprecated. * Also replace Replace mambaforge by miniforge now that conda uses the same solver as mamba.
Before, the Spyder source tree was nested inside the plugin source tree which was messy and may have generated errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes to the API, but mostly changes to ensure that the tests run.
Part of #221, but there is probably more to come.