PR: Use justified text instead of default left-alignment

[dalthviz]

Pull Request Checklist

• Read and followed this repo's Contributing Guidelines
• Based your PR on the latest version of the correct branch (master or 3.x)
• Checked your writing carefully for correct English spelling, grammar, etc
• Described your changes and the motivation for them below
• Noted what issue(s) this pull request resolves, creating one if needed

Description of Changes

Centered images look off with left-aligned text

Issue(s) Resolved

Fixes #170

[ccordoba12]

Thanks @dalthviz for this! Although this is the appropriate solution to make images really look centered, I think we agreed on a meeting not to justify our text and instead reduce the images margin-left a bit, so they seem centered with right justified text.

@juanis2112, what do you think about this one?

[juanis2112]

Yes @ccordoba12 , I do remember that's what we agreed on. However, @dalthviz can you post a screenshot to preview this change you made to see how it looks? Maybe this works too.

[dalthviz]

@ccordoba12 I was thinking in the option of changing the margin and at the end I decided to not go through that path since it could lead to cases where the images keep looking off and also it will mess up with the responsiveness of the page. @juanis2112 you can use the Netlify preview link to check how things are looking (you can see it if you click Show all checks)

[ccordoba12]

However, @dalthviz can you post a screenshot to preview this change you made to see how it looks? Maybe this works too.

@juanis2112, we have Netlify for that now. By pressing the Details link shown below, you'll get a live preview of this PR:

So you can browse all content and see how it looks with the text justified.

[ccordoba12]

I decided to not go through that path since it could lead to cases where the images keep looking off and also it will mess up with the responsiveness of the page.

Good point! I hadn't consider it!

Then I think we should go with the justified text.

[juanis2112]

However, @dalthviz can you post a screenshot to preview this change you made to see how it looks? Maybe this works too.

@juanis2112, we have Netlify for that now. By pressing the Details link shown below, you'll get a live preview of this PR:

So you can browse all content and see how it looks with the text justified.

Sorry I completely forgot about this. I'll try it now

[juanis2112]

I think justified text is fine, except for the text in the cards. I think we should leave that as it was before (centered) because otherwise looks weird. What do you think @ccordoba12 and @dalthviz ?

[ccordoba12]

I think justified text is fine, except for the text in the cards.

I was thinking exactly the same @juanis2112!

@dalthviz, is it possible to change that in custom_styles.css? Or does it need to be changed on the Sphinx theme?

[juanis2112]

Thanks @dalthviz

[CAM-Gerlach]

I don't think I personally mind the look of it, but justified text (and centered images) is a pretty unconventional choice for online documentation (or text in general in English; pretty much the only thing its used for is print newspaper articles). Looking over the docs for the five most prominent scientific/Python IDEs (PyCharm, JupyterLab, VSCode, Eclipse/PyDev, Rstudio), and scientific packages (Numpy, Scipy, Pandas, Matplotlib, IPython), all are left-aligned and where they have images, they are either full width or left-aligned too. As such, I think it would be best to have our UX expert @isabela-pf take at least a quick look at it first along with @juanis2112 .

Otherwise, if she agrees with the basic choice, I'm 👍 on this, I looked through the docs and didn't see any particular issues it caused.

[juanis2112]

Should we close this PR as we will not justify text @dalthviz, @ccordoba12 ?

[ccordoba12]

Agreed. Let's close it.