fix: fixed an issue where boolean string would not be transformed pro…

…perly with implicit transformation enabled

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
+## [2.2.1] - 2023-10-27
+
+### Fixed
+
+- Fixed an issue where boolean string would not be transformed properly with implicit transformation enabled.
+
 ## [2.2.0] - 2023-10-27
 
 ### Added

package.json

@@ -1,6 +1,6 @@
 {
   "name": "potber-api",
-  "version": "2.2.0",
+  "version": "2.2.1",
   "description": "A modern JSON API for forum.mods.de",
   "author": "",
   "private": true,

src/private-messages/controllers/queries/private-messages.find-many.query.ts

@@ -7,7 +7,7 @@ export class PrivateMessagesFindManyQuery {
   @IsOptional()
   folder?: PrivateMessageFolder;
 
-  @TransformBooleanString()
+  @TransformBooleanString('unread')
   @IsBoolean()
   @IsOptional()
   unread?: boolean;

src/threads/controllers/queries/threads.find-by-id.query.ts

@@ -17,7 +17,7 @@ export class ThreadsFindByIdQuery {
   @IsOptional()
   page?: number;
 
-  @TransformBooleanString()
+  @TransformBooleanString('updateBookmark')
   @IsBoolean()
   @IsOptional()
   updateBookmark: boolean;

src/threads/controllers/threads.controller.ts

@@ -87,6 +87,7 @@ export class ThreadsController {
     @Request() request: ExpressRequest,
     @Query() query: ThreadsFindByIdQuery,
   ): Promise<ThreadReadResource> {
+    console.log(query);
     return this.service.findById(id, request.user, {
       ...query,
     });

src/utility/transformers/boolean-string.transformer.ts

@@ -1,7 +1,11 @@
 import { Transform } from 'class-transformer';
 
-export function TransformBooleanString() {
-  return Transform(({ value }) => {
-    return value === 'true';
+/**
+ * Implicit conversion does not properly convert boolean strings, so we need to
+ * handle those manually.
+ */
+export function TransformBooleanString(key: string) {
+  return Transform(({ obj }) => {
+    return obj[key].toLowerCase() === 'true';
   });
 }