Merge pull request #113 from sproogen/revert-112-f/#105-button-tests

Revert "F/#105 button tests"
sproogen · Aug 14, 2017 · 45041ef · 45041ef
2 parents 135b7ae + c80bb5d
commit 45041ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 130 deletions.
diff --git a/app/Resources/client/src/components/Button/Button.js b/app/Resources/client/src/components/Button/Button.js
@@ -36,7 +36,7 @@ class Button extends React.Component {
     if (event) {
       event.preventDefault()
     }
-    if (!this.isDisabled() && this.props.callback) {
+    if (!this.isDisabled()) {
       this.setState({
         disabled : true,
         loading  : true
@@ -64,17 +64,15 @@ class Button extends React.Component {
 }
 
 Button.propTypes = {
-  text        : PropTypes.string,
+  text        : PropTypes.string.isRequired,
   className   : PropTypes.string,
   disabled    : PropTypes.bool,
-  callback    : PropTypes.func,
+  callback    : PropTypes.func.isRequired,
   submitEvent : PropTypes.string
 }
 
 Button.defaultProps = {
-  text      : '',
-  className : '',
-  disabled  : false,
+  disabled : false,
 }
 
 export default Button
diff --git a/app/Resources/client/tests/components/Button.spec.js b/app/Resources/client/tests/components/Button.spec.js