Fix Developers Logos Sizes #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
loicteixeira
commented
Jan 23, 2018
loicteixeira
commented
- Quick fix for truncated logos on developers index page. This will need further work, see Non square developers logos are cropped #105.
- Make logos on developers detail pages smaller (it was 4 times bigger than what its container allows it to be).
added 2 commits
January 24, 2018 08:24
The container has a fixed size of 7.5em, which with the base size of 16px corresponds to 120px. There is no reason to generate an image 500px wide. Also, using `max` instead of `width` to catch vertical logos as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.