Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non square developers logos are cropped #105

Open
loicteixeira opened this issue Jan 23, 2018 · 2 comments
Open

Non square developers logos are cropped #105

loicteixeira opened this issue Jan 23, 2018 · 2 comments
Labels

Comments

@loicteixeira
Copy link
Contributor

Developers logos currently use the fill-80x80-c100 rule which crops non-square logos.
current

Using max-80x80 doesn't crop it but doesn't look great either (althougth might be a good first quick fix).
max

We might need to write a custom filter which does the same as max-80x80 but also centers the image horizontally and vertically. Custom filters aren't documented but we can look at the implementation of the built-in filters and how to register them.

We might also want to look at #94 at the same time.

@loicteixeira
Copy link
Contributor Author

☝️ The PR above implement the quick max-80x80 fix but leaving the issue open as it will require more work to look good.

@haydngreatnews
Copy link
Member

Would it be easier to fix the vertical alignment of the logo in CSS?

max-80x80 would give an image that was (for example) 80 wide, and 20 high, and if the vertical alignment could be adjusted, it would save writing a whole new filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants