Remove 32-byte minimum keyLength restriction in Base64StringKeyGenerator
#17091
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator` (spring-projects#17012) Signed-off-by: Andrey Litvitski <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: crypto
|
Thanks for the PR @therepanic! I've scheduled this for merge as soon as the build passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this change is to essentially remove the strict 32 byte key length limit to allow developers to generate shorter Base64 strings if needed. Now, when trying to pass
keyLength < DEFAULT_KEY_LENGTH (32)into the constructor, an exception is thrown, which is not always justified for less critical token generation tasks.I believe that we don't need such a strict condition and we can soften the condition and just check that the key length is not less than or equal to 0.
Fix: #17012