Implement UserDetailsPasswordService in JdbcUserDetailsManager #16863 #16881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue Number: 16863 - Added UserDetailsPasswordService implementation to JdbcUserDetailsManager class. - Implemented updatePassword method to support password updates. Signed-off-by: Vasanth <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
requested changes
Apr 8, 2025
| @@ -64,7 +65,8 @@ | |||
| * @author Luke Taylor | |||
| * @since 2.0 | |||
| */ | |||
| public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsManager, GroupManager { | |||
| public class JdbcUserDetailsManager extends JdbcDaoImpl | |||
| implements UserDetailsManager, GroupManager, UserDetailsPasswordService { | |||
|
|
|||
There was a problem hiding this comment.
Please add a boolean property enableUpdatePassword which is false by default. The updatePassword method logic should only be ran if the property is true.
rwinch
added
status: waiting-for-feedback
|
Hi @vasanth-79, I noticed that the feedback provided by @rwinch on this PR about a month ago hasn't been addressed yet. Are you still planning to work on implementing these changes? If you're unable to continue for any reason, I'd be happy to pick this up and help finish it by incorporating the requested feedback. @rwinch, could you please advise on the best way to proceed if @vasanth-79 is no longer available? Thanks! |
spring-projects-issues
added
status: feedback-provided
|
Closing as declined due to lack of response to feedback @jhl221123 If you can comment on the original issue, I can assign it to you |
rwinch
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #16863