Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include UsernameNotFoundException in BadCredentialsException #16512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Include UsernameNotFoundException in BadCredentialsException #16512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...pringframework/security/authentication/dao/AbstractUserDetailsAuthenticationProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,9 @@ public Authentication authenticate(Authentication authentication) throws Authent
if (!this.hideUserNotFoundExceptions) {
throw ex;
}
throw new BadCredentialsException(this.messages
.getMessage("AbstractUserDetailsAuthenticationProvider.badCredentials", "Bad credentials"));
String message = this.messages.getMessage("AbstractUserDetailsAuthenticationProvider.badCredentials",
"Bad credentials");
throw new BadCredentialsException(message, ex);
}
Assert.notNull(user, "retrieveUser returned null - a violation of the interface contract");
}
Expand Down