-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adopt to AOT changes in Commons #4964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...b/src/main/java/org/springframework/data/mongodb/repository/support/QuerydslContributor.java
Show resolved
Hide resolved
...rc/main/java/org/springframework/data/mongodb/repository/support/MongoRepositoryFactory.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes make sense to me. I will adapt what I have done in Spring Data Cassandra to fit this as well. I have a couple of comments but other than that LGTM.
The interface resolution when generating the interface OwnerRepository extends Repository<Owner, Long> {
void save(Owner owner);
} {
"name": "save",
"signature": "public abstract void org.springframework.samples.petclinic.owner.OwnerRepository.save(org.springframework.samples.petclinic.owner.Owner)",
"fragment": {
"interface": "org.springframework.data.mongodb.repository.support.SimpleMongoRepository",
"fragment": "org.springframework.data.mongodb.repository.support.SimpleMongoRepository"
}
}, |
Yeah, I have no good idea to fix that yet. The |
Original Pull Request: #4964
merged to 5.0.x |
See spring-projects/spring-data-commons#3282