GH-3121 Throw PropertyReferenceException for whitespace-starting Prop… #3321
+14
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3121
So, actually, the situation that is described in the original ticket is quite flawed in many ways.
My basic assumption is that
PropertyPath
cannot hold whitespace holding properties. Now, the way it works withproperties. key
as the PropertyPath in spring data mongodb - it actually don't, we still were unable to parse thePropertyPath
, but we handed the exception - thePropertyReferenceException
.The mongodb can handles property references like
properties. key
, so the spring-data-mongodb just passed it literally asand the mongodb engine would figure it out.
Therefore, I think, that the only correct fix that can be applied here is to just throw a correct exception, which is
PropertyReferenceException
. Theproperties. key
andproperties. Key
should not be considered validPropertyPath
instances.CC: @christophstrobl @mp911de