Fix incorrect nullability contract for encoding in StaxEventItemReader - #5483
Closed
Gorock wants to merge 1 commit into
Closed
Fix incorrect nullability contract for encoding in StaxEventItemReader#5483Gorock wants to merge 1 commit into
Gorock wants to merge 1 commit into
Conversation
the encoding can be null based on the Documentation but Jspecify gives a warning when passing null. Which is confusing Signed-off-by: Daniel Morady <7807967+Gorock@users.noreply.github.com>
Gorock
force-pushed
the
FIX_Stax_Jspecify_Annotations
branch
from
August 6, 2026 16:24
d743965 to
5360c70
Compare
fmbenhassine
changed the title
Contributor
|
Good catch! Thank you for reporting this and for contributing a fix. Rebased and merged as ff4e7cf. Thank you for your first contribution 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encoding can be null Based on the Javadoc but Jspecify gives a warning when passing null. Which is confusing
this is my first Contribution to Spring Batch so please tell me if i forget something.