Restore persisted thought signatures in GoogleGenAiChatModel#6611
Open
ultramancode wants to merge 1 commit into
Open
Restore persisted thought signatures in GoogleGenAiChatModel#6611ultramancode wants to merge 1 commit into
GoogleGenAiChatModel#6611ultramancode wants to merge 1 commit into
Conversation
Signed-off-by: Taewoong Kim <ktw2172@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoogleGenAiChatModelstores Gemini thought signatures in assistant-message metadata asList<byte[]>and reattaches them when constructing subsequent function-call requests.Gemini requires function-calling thought signatures to be returned exactly as received so that reasoning context is preserved across requests.
When this metadata is serialized to JSON and deserialized as
Object, the Javabyte[]type is not preserved.Gson reads JSON arrays as
Listvalues withDoubleelements, andRedisChatMemoryRepositoryuses this serialization path.Consequently, a persisted signature has this shape after it is loaded:
The existing request conversion verifies only that the metadata value is a
List, not that its elements arebyte[].When the signature is attached to the next function-call part, the inner numeric list is cast to
byte[], causing aClassCastExceptionbefore the request reaches Gemini.To reproduce the failure:
AssistantMessagecontaining a function call and athoughtSignaturesmetadata value.RedisChatMemoryRepository.ClassCastExceptionwhileGoogleGenAiChatModelconstructs the request.