Propagate custom headers for OpenAI embeddings#6575
Open
flex-ilsub wants to merge 1 commit into
Open
Conversation
OpenAiEmbeddingOptions#toOpenAiCreateParams built the request from model/input/user/encodingFormat/dimensions only, silently dropping per-call customHeaders. This mirrors the fix already applied to chat (OpenAiChatModel#createRequest) and images (spring-projects#6083), so a single embedding client can forward per-request headers (e.g. tracing or gateway identifiers) to the OpenAI API. Fixes spring-projects#6574 Signed-off-by: Il Sub Bang <ilsub@flex.team> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
Please let me know if it's an issue that Claude is listed as Co-Authored-By in the commit. If it is, I can amend the commit and recreate the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAiEmbeddingOptions#toOpenAiCreateParams built the request from model/input/user/encodingFormat/dimensions only, silently dropping per-call customHeaders. As a result, a shared embedding client could not forward per-request headers (e.g. distributed-tracing identifiers or LLM-gateway headers) to the OpenAI API.
This mirrors the fix already applied to chat (OpenAiChatModel#createRequest, propagating per-call headers via putAdditionalHeader) and images (#6083), applying the same pattern to the embedding path.
Fixes #6574
🤖 Generated with Claude Code