OpenAI: support any path configuration #3452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lambochen <[email protected]>
Signed-off-by: lambochen <[email protected]>
Signed-off-by: lambochen <[email protected]>
Signed-off-by: lambochen <[email protected]>
lambochen
changed the title
|
@markpollack @tzolov @ilayaperumalg Hi, please review the PR, thank you. |
dev-jonghoonpark
suggested changes
Jun 6, 2025
...ls/spring-ai-openai/src/main/java/org/springframework/ai/openai/api/OpenAiModerationApi.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lambochen <[email protected]>
...ing-ai-openai/src/main/java/org/springframework/ai/openai/api/common/OpenAiApiConstants.java
Outdated
Show resolved
Hide resolved
...ls/spring-ai-openai/src/main/java/org/springframework/ai/openai/api/OpenAiModerationApi.java
Outdated
Show resolved
Hide resolved
models/spring-ai-openai/src/main/java/org/springframework/ai/openai/api/OpenAiAudioApi.java
Outdated
Show resolved
Hide resolved
models/spring-ai-openai/src/main/java/org/springframework/ai/openai/api/OpenAiAudioApi.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/ai/model/openai/autoconfigure/OpenAiAudioSpeechAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/ai/model/openai/autoconfigure/OpenAiModerationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...springframework/ai/model/openai/autoconfigure/OpenAiAudioTranscriptionAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ls/spring-ai-openai/src/main/java/org/springframework/ai/openai/api/OpenAiModerationApi.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lambochen <[email protected]>
Signed-off-by: lambochen <[email protected]>
Signed-off-by: lambochen <[email protected]>
Signed-off-by: lambochen <[email protected]>
| @ConfigurationProperties(OpenAiChatProperties.CONFIG_PREFIX) | ||
| public class OpenAiChatProperties extends OpenAiParentProperties { | ||
|
|
||
| public static final String CONFIG_PREFIX = "spring.ai.openai.chat"; | ||
|
|
||
| public static final String DEFAULT_CHAT_MODEL = "gpt-4o-mini"; | ||
|
|
||
| public static final String DEFAULT_COMPLETIONS_PATH = "/v1/chat/completions"; | ||
| public static final String DEFAULT_COMPLETIONS_PATH = OpenAiApiConstants.DEFAULT_COMPLETIONS_PATH; |
There was a problem hiding this comment.
OpenAiChatProperties.DEFAULT_COMPLETIONS_PATH can be replaced with OpenAiApiConstants.DEFAULT_COMPLETIONS_PATH.
Is there any reason to keep OpenAiChatProperties.DEFAULT_COMPLETIONS_PATH anymore? Both are public static final.
OpenAiEmbeddingProperties.DEFAULT_EMBEDDINGS_PATH and OpenAiImageProperties.DEFAULT_IMAGES_PATH are the same as well.
There was a problem hiding this comment.
Hi, @dev-jonghoonpark .
To ensure compatibility with lower versions (as these attributes are all public and may have been referenced in user business code), OpenAiChatProperties.DEFAULT_COMPLETIONS_PATH, OpenAiEmbeddingProperties.DEFAULT_EMBEDDINGS_PATH, and OpenAiImageProperties.DEFAULT_IMAGES_PATH have been retained.
However, they have all been moved to OpenAiApiConstants for unified management.
...ing-ai-openai/src/main/java/org/springframework/ai/openai/api/common/OpenAiApiConstants.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lambochen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commitsref issue: #3451
OpenAI's audio and moderation configuration paths are supported, as detailed below: