Fix: MySQL/MariaDB TIMESTAMP precision for message ordering (#3442) #3443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rojects#3442) Fixes spring-projects#3442 Signed-off-by: Seungwon Lee <[email protected]>
sunyuhan1998
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
I think this PR itself is fine, but as @markpollack previously mentioned:
this field is actually being used as an auto-incrementing sequence to ensure message ordering, rather than representing time in a temporal sense. Perhaps we should consider renaming this field in the future.
|
There is a common belief that https://stackoverflow.com/questions/409286/should-i-use-the-datetime-or-timestamp-data-type-in-mysql |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3442
The
AddBatchPreparedStatementclass usesAtomicLong.getAndIncrement()to create sequential millisecond timestamps, but MySQL/MariaDB's default TIMESTAMP precision (0) truncates this information, causing message ordering issues.Added fractional seconds precision (TIMESTAMP(3)) to MySQL and MariaDB schemas to support millisecond-based message ordering in
JdbcChatMemoryRepository.Changes
schema-mysql.sql: ChangedTIMESTAMPtoTIMESTAMP(3)schema-mariadb.sql: ChangedTIMESTAMPtoTIMESTAMP(3)